[webkit-reviews] review granted: [Bug 64774] DFG JIT sometimes emits spill code even when the respective values are never needed : [Attachment 101268] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 19 11:10:48 PDT 2011


Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 64774: DFG JIT sometimes emits spill code even when the respective values
are never needed
https://bugs.webkit.org/show_bug.cgi?id=64774

Attachment 101268: the patch
https://bugs.webkit.org/attachment.cgi?id=101268&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Per our last discussion I'd quite like to refactor this to make the RAII
pattern a little more useful here, and try to make some of this more automatic
- but we already have the issue of requiring that gpr() is called at the right
point, and this all looks fine.


More information about the webkit-reviews mailing list