[webkit-reviews] review granted: [Bug 64812] Buildbot marks a nrwt bot red when tests are missing results : [Attachment 101342] fixes the bug

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 64812: Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Attachment 101342: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=101342&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101342&action=review


> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:319
> -		   if result != FAILURE and (line.find('were flaky') >= 0 or
line.find('new passes') >= 0):
> +		   if result != FAILURE and (line.find('flakes') >= 0 or
line.find('new passes') >= 0 or line.find('missing results') >= 0):
>		       result = WARNINGS
>		   else:
>		       result = FAILURE

Nit: Can we just return on FAILURE and remove the check in the warnings code?