[webkit-reviews] review denied: [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port : [Attachment 101337] Fix the tab switch issue

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>'s request for review:
Bug 64790: [GTK][WK2] Handle doneWithKeyEvent in GTK port
https://bugs.webkit.org/show_bug.cgi?id=64790

Attachment 101337: Fix the tab switch issue
https://bugs.webkit.org/attachment.cgi?id=101337&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101337&action=review


Looks good, but I have a few nits.

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:216
> +						reinterpret_cast<const
GdkEventKey*>(event.nativeEvent()));

The indentation is off here and you should just do: &event.nativeEvent()->key
or similar.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:330
> +		   GTK_WIDGET(webViewBase),
> +		   const_cast<GdkEventKey*>(keyEvent));

No need to break this line. It isn't right to simply cast away the constness
here. The NativeWebKeyboardEvent is not expecting the GdkEventKey to change.
Probably it's better to make a copy of the event and send that.