[webkit-reviews] review granted: [Bug 60850] SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef> : [Attachment 101295] Patch v8

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 60850: SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and
<glyphRef>
https://bugs.webkit.org/show_bug.cgi?id=60850

Attachment 101295: Patch v8
https://bugs.webkit.org/attachment.cgi?id=101295&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101295&action=review


Looks great, r=me. I've told Leo to watch the bots after landing to rebaseline
all platforms that have unique prototype-inheritance.html results.

> Source/WebCore/svg/SVGGlyphRefElement.idl:25
> +	   attribute DOMString glyphRef

Please add a FIXME here that this is supposed to use Reflect, but has a bug.
Also please file a bug on this, that it's impossible to use Reflect on such
attributes at present.
Even better would be a fix of the generators of course :-)