[webkit-reviews] review granted: [Bug 64522] WebSocket: Implement hybi framing : [Attachment 101281] Patch v4

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 64522: WebSocket: Implement hybi framing
https://bugs.webkit.org/show_bug.cgi?id=64522

Attachment 101281: Patch v4
https://bugs.webkit.org/attachment.cgi?id=101281&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101281&action=review


> Source/WebCore/websockets/WebSocketChannel.cpp:466
> +#if COMPILER(MSVC)
> +    static const uint64_t maxPayloadLength = 0x7FFFFFFFFFFFFFFFui64;
> +#else
> +    static const uint64_t maxPayloadLength = 0x7FFFFFFFFFFFFFFFull;
> +#endif

nit: It's nice to have a comment that we wanted to use UINT64_C.

> Source/WebCore/websockets/WebSocketChannel.cpp:468
> +    if (payloadLength64 > maxPayloadLength || payloadLength64 +
maskingKeyLength > std::numeric_limits<size_t>::max()) {

nit: We usually declare "using namespace std;" at the beginning of the file and
omit std::.