[webkit-reviews] review granted: [Bug 64571] ARMv7 backend broken, lacks 3 parameter rshift32 method : [Attachment 100885] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 18 23:19:09 PDT 2011


Zoltan Herczeg <zherczeg at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 64571: ARMv7 backend broken, lacks 3 parameter rshift32 method
https://bugs.webkit.org/show_bug.cgi?id=64571

Attachment 100885: Patch
https://bugs.webkit.org/attachment.cgi?id=100885&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
LGTM.

On x86-32, all three shifts have 3 operand opcode, might be a good idea to add
them later. But this patch is basically a build-fix, and should be landed.


More information about the webkit-reviews mailing list