[webkit-reviews] review denied: [Bug 64644] Implement WaveShaperNode for Web Audio API : [Attachment 101226] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 64644: Implement WaveShaperNode for Web Audio API
https://bugs.webkit.org/show_bug.cgi?id=64644

Attachment 101226: Patch
https://bugs.webkit.org/attachment.cgi?id=101226&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101226&action=review


The patch generally looks good but there are a couple of seemingly unrelated
changes that should be split into a separate bug.

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:96
> -	       return jsUndefined();
> +	       return throwVMError(exec, createSyntaxError(exec, "Error
creating OfflineAudioContext"));

This change looks unrelated to this patch.

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:147
> -	   return throwVMError(exec, createSyntaxError(exec, "Invalid number of
channels"));
> +	   return throwError(exec, createSyntaxError(exec, "Invalid number of
channels"));
>  
>      if (numberOfFrames <= 0)
> -	   return throwVMError(exec, createSyntaxError(exec, "Invalid number of
frames"));
> +	   return throwError(exec, createSyntaxError(exec, "Invalid number of
frames"));
>  
>      if (sampleRate <= 0)
> -	   return throwVMError(exec, createSyntaxError(exec, "Invalid sample
rate"));
> +	   return throwError(exec, createSyntaxError(exec, "Invalid sample
rate"));

These as well.