[webkit-reviews] review requested: [Bug 57154] [Qt] Make OpenGL symbol resolver transparent : [Attachment 101209] use OpenGLShims resolver implementation

[bugzilla-daemon at webkit.org]

Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 57154: [Qt] Make OpenGL symbol resolver transparent
https://bugs.webkit.org/show_bug.cgi?id=57154

Attachment 101209: use OpenGLShims resolver implementation
https://bugs.webkit.org/attachment.cgi?id=101209&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
(In reply to comment #29)
> It's a pretty big patch; Hard to review...
> Could you break it down a bit

The patch had some additional changes not directly related to adopting the
shims resolver - it was also removing things from GraphicsContext3DInternal and
using the corresponding members in GraphicsContext3D instead - holdovers from
jarkkos original patch.

I'm going to move those changes to separate patches for bug 57261 where they
belong, and this patch now only addresses changing the symbol resolver.

So this patch is still kind of big, but very straightforward. It just deletes a
bunch of typedefs, proc member declarations and assignments that were the old
resolver. Then it changes each call to the old symbol resolver to use the new
one (e.g. m_internal->bindFramebuffer becomes glBindFramebuffer etc.) - so just
a bunch of single line diffs where it's very clear what is changing.

I think this will be much easier to review.