[webkit-reviews] review granted: [Bug 63994] [GTK] Google Calendar thinks we're mobile : [Attachment 100357] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 63994: [GTK] Google Calendar thinks we're mobile
https://bugs.webkit.org/show_bug.cgi?id=63994

Attachment 100357: Patch
https://bugs.webkit.org/attachment.cgi?id=100357&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100357&action=review


Looks cool in general. The mess with the style stuff in the .c files breaks my
heart.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1418
> +	   initializeDomainsList(googleDomains);

I'd rather have both of these initialized in their own methods, in the same way
(ie, add vs append). I know, OCD.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1492
> +    return g_strdup(webkit_web_settings_get_user_agent(webSettings));

If you rewrite this to do if (quirkcs) { ....} you can get rid of the
duplicated "return g_strdup(webkit_web_settings_get_user_agent(webSettings));".
Just saying.