[webkit-reviews] review denied: [Bug 64745] JSC GC lazy sweep does not inline the common cases of cell destruction : [Attachment 101197] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 64745: JSC GC lazy sweep does not inline the common cases of cell
destruction
https://bugs.webkit.org/show_bug.cgi?id=64745

Attachment 101197: the patch
https://bugs.webkit.org/attachment.cgi?id=101197&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101197&action=review


r- :(

> Source/JavaScriptCore/heap/MarkedBlock.cpp:96
> +	       if (*reinterpret_cast<void**>(cell) == jsFinalObjectVPtr) {

use cell->vptr();

> Source/JavaScriptCore/heap/MarkedBlock.cpp:99
> +		   if (!object->isUsingInlineStorage())
> +		       delete [] object->m_propertyStorage;

object->JSFinalObject::~JSFinalObject() didn't work?