[webkit-reviews] review requested: [Bug 64541] [Qt] Consider the scale of the page view when scrolling QTouchWebView. : [Attachment 101149] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 18 05:21:28 PDT 2011


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 64541: [Qt] Consider the scale of the page view when scrolling
QTouchWebView.
https://bugs.webkit.org/show_bug.cgi?id=64541

Attachment 101149: Patch
https://bugs.webkit.org/attachment.cgi?id=101149&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
New patch using mapFromItem instead of mapToParent.
I tried assuming that mapFromParent(pos()) and remove the call, but the
assumption wouldn't hold when scaling the item, event though the documentation
says it should (it might not help that we set a different transform origin on
that item.).


More information about the webkit-reviews mailing list