[webkit-reviews] review granted: [Bug 64223] WebFrame should have a method to determine its visual emptiness : [Attachment 101108] proposed patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Ian Henderson <ianh at apple.com>'s request for
review:
Bug 64223: WebFrame should have a method to determine its visual emptiness
https://bugs.webkit.org/show_bug.cgi?id=64223

Attachment 101108: proposed patch
https://bugs.webkit.org/attachment.cgi?id=101108&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=101108&action=review


> Source/WebKit/mac/WebView/WebFramePrivate.h:77
>  - (BOOL)_firstLayoutDone;
> +- (BOOL)_didFirstVisuallyNonEmptyLayout;

I’d call this _firstVisuallyNonEmptyLayoutDone. I think a message named did…
often implies that the sender did something and is notifying the receiver of
that. Perhaps a better name for both would have been hasDone….