[webkit-reviews] review denied: [Bug 64059] REGRESSION (r88913):=?UTF-8?Q?=20Preview=20in=20Safari=E2=80=99s=20snippet=20editor=20has=20a=20fixed=20height=20instead=20of=20filling=20the=20entire=20pane=20?=: [Attachment 100976] Patch v6

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 64059: REGRESSION (r88913): Preview in Safari’s snippet editor has a fixed
height instead of filling the entire pane
https://bugs.webkit.org/show_bug.cgi?id=64059

Attachment 100976: Patch v6
https://bugs.webkit.org/attachment.cgi?id=100976&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100976&action=review


Looks fine overall, r- because of my question.

> Source/WebCore/ChangeLog:16
> +	   wheter the height property is set on the containing block, there are
other ways to implicitly specify

wheter -> whether

> Source/WebCore/rendering/RenderReplaced.cpp:323
> +	       return false;

Can you tell me how the above while relates to this for? For instance where
does the isTableCell check come from?