[webkit-reviews] review granted: [Bug 64140] REGRESSION: Pressing return in a particular document sends the cursor to the end of the document : [Attachment 101105] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 64140: REGRESSION: Pressing return in a particular document sends the
cursor to the end of the document
https://bugs.webkit.org/show_bug.cgi?id=64140

Attachment 101105: Patch
https://bugs.webkit.org/attachment.cgi?id=101105&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101105&action=review


> Source/WebCore/ChangeLog:9
> +	   The fix consists in detecting that the insertion point is a break
element and simply insert another

insert -> inserting

> Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:307
> +	   if (visiblePos.deepEquivalent().anchorNode()->renderer()->isBR()) {

Is anchorNode() guaranteed to have a renderer?