[webkit-reviews] review denied: [Bug 64560] [Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older : [Attachment 100977] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 16 15:00:21 PDT 2011


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Hui Huang
<hui_huang at yahoo.com>'s request for review:
Bug 64560: [Qt] Compiling error in
Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
https://bugs.webkit.org/show_bug.cgi?id=64560

Attachment 100977: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=100977&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review


> Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026
> +#if QT_VERSION >= 0x040800

Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800


More information about the webkit-reviews mailing list