[webkit-reviews] review denied: [Bug 64580] Add support for download='filename' in anchors : [Attachment 101090] Always allow data URLs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 15 21:55:02 PDT 2011
Adam Barth <abarth at webkit.org> has denied sadrul at chromium.org's request for
review:
Bug 64580: Add support for download='filename' in anchors
https://bugs.webkit.org/show_bug.cgi?id=64580
Attachment 101090: Always allow data URLs
https://bugs.webkit.org/attachment.cgi?id=101090&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101090&action=review
> Source/WebCore/html/HTMLAnchorElement.cpp:506
> + if (download && (kurl.protocolIsData() ||
document()->securityOrigin()->canRequest(kurl))) {
Please don't add special cases for data URLs. The data URL bug is part of a
larger problem in WebKit.
More information about the webkit-reviews
mailing list