[webkit-reviews] review granted: [Bug 63674] Get webkit to compile with USE(CFNETWORK) enabled on Mac : [Attachment 101072] Downloads in webkit1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 63674: Get webkit to compile with USE(CFNETWORK) enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=63674

Attachment 101072: Downloads in webkit1
https://bugs.webkit.org/attachment.cgi?id=101072&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101072&action=review


r=me

> Source/WebKit/mac/Misc/WebDownload.mm:261
> +    [self _setRealDelegate:delegate];
> +    return [super _initWithLoadingCFURLConnection:connection request:request
response:response delegate:_webInternal proxy:proxy];

Shouldn't you set self first before calling -_setRealDelegate: here?

    self = [super _initWithLoadingCFURLConnection:connection request:request
response:response delegate:_webInternal proxy:proxy];
    if (!self)
	return nil;
    [self _setRealDelegate:delegate];
    return self;