[webkit-reviews] review requested: [Bug 64580] Add support for download='filename' in anchors : [Attachment 101085] Check origin before downloading

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 15 19:03:44 PDT 2011


sadrul at chromium.org has asked  for review:
Bug 64580: Add support for download='filename' in anchors
https://bugs.webkit.org/show_bug.cgi?id=64580

Attachment 101085: Check origin before downloading
https://bugs.webkit.org/attachment.cgi?id=101085&action=review

------- Additional Comments from sadrul at chromium.org
As per the discussion, I have made the change to check the origin first before
allowing download. With this change, blob URLs, filesystem URLs and URLs for
the same origin can be downloaded. Otherwise, the 'download' attribute is
silently ignored. Or would it be more desirable to not follow the link at all
and show an error to the user instead?


More information about the webkit-reviews mailing list