[webkit-reviews] review granted: [Bug 64564] [NRWT] Add support for --no-http : [Attachment 101060] Proposed fix 3: With more python-ness thanks to Eric & Dirk.

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 64564: [NRWT] Add support for --no-http
https://bugs.webkit.org/show_bug.cgi?id=64564

Attachment 101060: Proposed fix 3: With more python-ness thanks to Eric & Dirk.
https://bugs.webkit.org/attachment.cgi?id=101060&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101060&action=review


Looks great; just a few nits. Thanks for fixing this!

> Tools/Scripts/webkitpy/layout_tests/port/test.py:181
> +    # For --no-http tests.

Nit: I might be a bit more verbose and note that we test to make sure
platform-specific http tests are skipped as well.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:654
> +	   self.assertTrue(passing_run(['--no-http']))

Nit: I wouldn't bother with this since you have test_no_http(), below.