[webkit-reviews] review granted: [Bug 64504] Focus and selection events are not fired when a <select>'s selection changes : [Attachment 100957] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 15 14:51:14 PDT 2011


Alice Liu <alice.liu at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 64504: Focus and selection events are not fired when a <select>'s selection
changes
https://bugs.webkit.org/show_bug.cgi?id=64504

Attachment 100957: Patch v2
https://bugs.webkit.org/attachment.cgi?id=100957&action=review

------- Additional Comments from Alice Liu <alice.liu at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100957&action=review


r=me assuming the location of the early return in didSetSelectedIndex is either
fine or fixed up.

> Source/WebCore/rendering/RenderMenuList.cpp:353
> +

It looks like didSetSelectedIndex used to set m_lastSelectedIndex even if
accessibilityEnabled was false.  Now you're not going to be setting
m_lastActiveIndex if accessibility isn't enabled.  I guess that's okay if
m_lastActiveIndex is only ever read or written if accessibility is enabled, but
i can't tell 100% from this patch.  could you confirm this?


More information about the webkit-reviews mailing list