[webkit-reviews] review granted: [Bug 64619] TestFailures page thinks all tests passed in http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401 : [Attachment 101029] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 64619: TestFailures page thinks all tests passed in
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tes
ts)/builds/13401
https://bugs.webkit.org/show_bug.cgi?id=64619

Attachment 101029: Patch
https://bugs.webkit.org/attachment.cgi?id=101029&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101029&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builde
r.js:138
> +	       if (layoutTestStep.results[0] === 4) {

I wish we could make this less magical. Maybe it would make things a bit
clearer if results was a dictionary instead of an array so that we can refer to
its values using keys instead of indices. Also, defining a named constant for 4
may help as well.