[webkit-reviews] review granted: [Bug 64605] Move expectation parsing code to TestExpectationsParser. : [Attachment 101004] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 64605: Move expectation parsing code to TestExpectationsParser.
https://bugs.webkit.org/show_bug.cgi?id=64605

Attachment 101004: Patch
https://bugs.webkit.org/attachment.cgi?id=101004&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101004&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:208
> +	   has_wontfix = 'wontfix' in expectation.modifiers

Ojan would tell you to make 'wontfix' a string constant instead of a string
literal.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:210
> +	   for opt in expectation.modifiers:

opt => option or modifier ?