[webkit-reviews] review granted: [Bug 64594] test-webkitpy failing with Python 2.5 : [Attachment 100964] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 64594: test-webkitpy failing with Python 2.5
https://bugs.webkit.org/show_bug.cgi?id=64594

Attachment 100964: proposed patch
https://bugs.webkit.org/attachment.cgi?id=100964&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100964&action=review


> Tools/ChangeLog:11
> +	   Updated simplejson to version 2.1.6 that fixes an issue when
> +	   dumping slashes. Also use cgi.parse_qs instead of the urlparse
> +	   version to be compatible with Python2.5. Verified the fix with
> +	   test-webkitpy on python 2.5 and python 2.6.

Ok.  So you're just updating simplejson, and then separately making changes to
our code, correct?  You're not changing simplejson besides the update?