[webkit-reviews] review granted: [Bug 64542] Move TransformState to platform/graphics and give it the option to transform just a FloatQuad : [Attachment 101009] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 15 11:21:04 PDT 2011
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 64542: Move TransformState to platform/graphics and give it the option to
transform just a FloatQuad
https://bugs.webkit.org/show_bug.cgi?id=64542
Attachment 101009: Patch
https://bugs.webkit.org/attachment.cgi?id=101009&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101009&action=review
> Source/WebCore/platform/graphics/transforms/TransformState.cpp:29
> +#include <wtf/PassOwnPtr.h>
Don't need this include.
> Source/WebCore/platform/graphics/transforms/TransformState.h:2
> + * Copyright (C) 2009 Apple Inc. All rights reserved.
+2011
> Source/WebCore/platform/graphics/transforms/TransformState.h:34
> +#include <wtf/PassRefPtr.h>
Not needed?
> Source/WebCore/platform/graphics/transforms/TransformState.h:36
> +#include <wtf/RefCounted.h>
Not needed?
> Source/WebCore/rendering/HitTestingTransformState.cpp:2
> + * Copyright (C) 2009 Apple Inc. All rights reserved.
Add 2011 too.
> Source/WebCore/rendering/HitTestingTransformState.h:40
> +// So there's really no need for a ref counted version. So This class should
be tossed and replaced
s/tossed/removed :)
More information about the webkit-reviews
mailing list