[webkit-reviews] review granted: [Bug 18356] Stroking of zero-length paths in SVG should change according to erratum : [Attachment 100982] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 18356: Stroking of zero-length paths in SVG should change according to
erratum
https://bugs.webkit.org/show_bug.cgi?id=18356

Attachment 100982: Patch
https://bugs.webkit.org/attachment.cgi?id=100982&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100982&action=review


Great, r=me. You may want to fix some last things before landing:

> Source/WebCore/rendering/svg/RenderSVGPath.cpp:194
> +    context->concatCTM(nonScalingStrokeTransform.inverse());

it seems nicer to give the GraphicsContextStateSaver a "GraphicsContext*
context" accessor, as it already stores it. You'd save having to hand over
GraphicsContext as argument then.
I'd do it.

> Source/WebCore/rendering/svg/RenderSVGPath.cpp:358
> +    const SVGRenderStyle* svgStyle = style()->svgStyle();

This can be reverted to the old position.

> Source/WebCore/rendering/svg/RenderSVGPath.cpp:391
> +

Not needed?