[webkit-reviews] review denied: [Bug 64596] Web Inspector: arrays in object properties sections do not scale. : [Attachment 100968] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 15 08:10:17 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 64596: Web Inspector: arrays in object properties sections do not scale.
https://bugs.webkit.org/show_bug.cgi?id=64596
Attachment 100968: Patch
https://bugs.webkit.org/attachment.cgi?id=100968&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100968&action=review
Let's make sure that it works for object property section as well, r- for now.
> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:81
> + var expandableArrayThreashold = 100;
typo: threashold -> threshold
> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:90
> + if (index >= 0 && (index < minIndex || minIndex == -1))
if -> else if?
== -> ===
More information about the webkit-reviews
mailing list