[webkit-reviews] review denied: [Bug 63930] Pixel difference in FEMorphology effect : [Attachment 100943] Pixel difference in FEMorphology effect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 15 05:33:00 PDT 2011


Zoltan Herczeg <zherczeg at webkit.org> has denied Gabor Loki <loki at webkit.org>'s
request for review:
Bug 63930: Pixel difference in FEMorphology effect
https://bugs.webkit.org/show_bug.cgi?id=63930

Attachment 100943: Pixel difference in FEMorphology effect
https://bugs.webkit.org/attachment.cgi?id=100943&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100943&action=review


> Source/WebCore/svg/SVGFEMorphologyElement.cpp:132
> +    if (attrName == SVGNames::radiusAttr) {
> +	   bool isRadiusXChanged = morphology->setRadiusX(radiusX());
> +	   bool isRadiusYChanged = morphology->setRadiusY(radiusY());
> +	   return isRadiusXChanged || isRadiusYChanged;
> +    }

Please put a comment here why this form is needed.


More information about the webkit-reviews mailing list