[webkit-reviews] review denied: [Bug 39578] IME: no underline is shown when entering Japanese preedit text in an input box on QtWebKit : [Attachment 99267] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 15 04:15:44 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has denied Tasuku Suzuki
<tasuku.suzuki at nokia.com>'s request for review:
Bug 39578: IME: no underline is shown when entering Japanese preedit text in an
input box on QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=39578

Attachment 99267: proposed patch
https://bugs.webkit.org/attachment.cgi?id=99267&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #12)
> The patch doesn't seem to solve the original problem directly.

You should fully understand the problem in order to write a solution. The patch
might solve part of the problem, or hide it.

This also makes it impossible for us to review. You should explain what was
going on that was causing the problem, and why this patch is the correct
solution.

Please investigate what is going on here, and improve the changelog. If you can
reproduce the problem on Safari or Chromium, you should also add a pixel test.


More information about the webkit-reviews mailing list