[webkit-reviews] review denied: [Bug 64525] MediaStream API: Release script objects when detaching document : [Attachment 100945] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has denied Henrik Grunell
<grunell at google.com>'s request for review:
Bug 64525: MediaStream API: Release script objects when detaching document
https://bugs.webkit.org/show_bug.cgi?id=64525

Attachment 100945: Patch
https://bugs.webkit.org/attachment.cgi?id=100945&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100945&action=review


r- for lack of test

> Source/WebCore/ChangeLog:10
> +	   No new tests because the patch is just a bug fix.

In WebKit, fixing a bug is usually a great reason to add a test. This is the
sort of edge case that could easily break during future refactoring, so please
add a test so we don't regress here.

> Source/WebCore/dom/Document.cpp:1778
> +	   if (mediaStreamFrameController)

If you prefer, a common idiom in WebKit is:

if (MediaStreamFrameController* mediaStreamFrameController =
m_frame->mediaStreamFrameController())
    mediaStreamFrameController->clearAllClients();