[webkit-reviews] review granted: [Bug 64588] gardening server should proxy buildbot status for garden-o-matic : [Attachment 100948] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 64588: gardening server should proxy buildbot status for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=64588

Attachment 100948: Patch
https://bugs.webkit.org/attachment.cgi?id=100948&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100948&action=review


OK.

> Tools/Scripts/webkitpy/tool/mocktool.py:841
> +	   self._chromium_buildbot = MockBuildBot()

MIght want to give it a differnet url.

> Tools/Scripts/webkitpy/tool/mocktool.py:859
> +    def chromium_buildbot(self):
> +	   return self._chromium_buildbot

we should figure out if we should move to @property-style getters one of these
days.