[webkit-reviews] review requested: [Bug 64345] [Win] On-the-spot IME support for windowless plug-ins : [Attachment 100947] Patch v1 (added a layout test)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 15 01:36:33 PDT 2011
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 64345: [Win] On-the-spot IME support for windowless plug-ins
https://bugs.webkit.org/show_bug.cgi?id=64345
Attachment 100947: Patch v1 (added a layout test)
https://bugs.webkit.org/attachment.cgi?id=100947&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,
I have added a layout test that verifies WM_IME_* messages to a plug-in. (This
test is the same one as the one used in <http://webkit.org/b/61272>.)
Unfortunately, this change becomes much bigger than the previous one because I
needed to implement TextInputController for the test. Also, this change copied
event-sending code from Editor::setComposition() and
Editor::confirmComposition. (I think it is a good idea to merge them as written
in my previous comment.)
I would like to set r? so I can try building this change on EWS bots.
Regards,
Hironori Bono
More information about the webkit-reviews
mailing list