[webkit-reviews] review granted: [Bug 64586] NRWT stores the Chromium revision number in full_results.json : [Attachment 100946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 15 01:20:48 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 64586: NRWT stores the Chromium revision number in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=64586

Attachment 100946: Patch
https://bugs.webkit.org/attachment.cgi?id=100946&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100946&action=review


OK.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:612
> +	   # FIXME: Due to Chromium's insane DEPS system, the root of the
WebKit

Well the DEPS system isn't insane, just their setup.


More information about the webkit-reviews mailing list