[webkit-reviews] review denied: [Bug 64564] [NRWT] Add support for --no-http : [Attachment 100872] Proposed implementation

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 64564: [NRWT] Add support for --no-http
https://bugs.webkit.org/show_bug.cgi?id=64564

Attachment 100872: Proposed implementation
https://bugs.webkit.org/attachment.cgi?id=100872&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100872&action=review


This looks great except for the web socket server issue!

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:356
> +	   httpTests = set()

httpTests => http_tests (Python PEP8 style uses unix_hacke style names)

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:358
> +	       if test.find(self.HTTP_SUBDIR, 0) is not -1:

This looks like a really elaborate "test.startswith(self.HTTP_SUBDIR)"

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:394
> +	   # Remove HTTP test if option set up.

This comment can be removed.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:956
> +	       self._printer.print_update('Starting WebSocket server ...')
> +	       self._port.start_websocket_server()

Presumably we should still start the web socket server even if we're not going
to run HTTP tests.