[webkit-reviews] review requested: [Bug 64580] Add support for download='filename' in anchors : [Attachment 100933] directly call startDownload

[bugzilla-daemon at webkit.org]

sadrul at chromium.org has asked  for review:
Bug 64580: Add support for download='filename' in anchors
https://bugs.webkit.org/show_bug.cgi?id=64580

Attachment 100933: directly call startDownload
https://bugs.webkit.org/attachment.cgi?id=100933&action=review

------- Additional Comments from sadrul at chromium.org
I have made the change to call startDownload early directly from
HTMLAnchorElement instead of going through urlSelected. Some notes:
 (1) I have tried to make sure that the ResourceRequest is properly updated
with the referrer, user-agent etc. by adding
FrameLoader::prepareResourceRequest
 (2) Added an optional 'String& suggestedName' parameter to
WebCore::FrameLoaderClient::startDownload. It's currently unused in all
implementations, but if this looks reasonable, I will hook it up at least for
chromium.

I really appreciate the quick reviews. Thanks!