[webkit-reviews] review granted: [Bug 64565] Store error and warning information on TestExpectationLine. : [Attachment 100874] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 64565: Store error and warning information on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64565

Attachment 100874: Patch
https://bugs.webkit.org/attachment.cgi?id=100874&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100874&action=review


This looks good.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316
>	   # FIXME: Shouldn't return anything, this is a temporary layering
volation.

Presumably this FIXME is now fixed.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:644
> +	       lineno += 1

I think there's a way to iterate over a list that will give you the list index
during the iteration.