[webkit-reviews] review granted: [Bug 64573] DFG JIT is inconsistent about fusing branches and speculating integer comparisons for branches : [Attachment 100908] the patch (fix style)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 22:34:37 PDT 2011


Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 64573: DFG JIT is inconsistent about fusing branches and speculating
integer comparisons for branches
https://bugs.webkit.org/show_bug.cgi?id=64573

Attachment 100908: the patch (fix style)
https://bugs.webkit.org/attachment.cgi?id=100908&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
static_cast<int32_t>(1) seems a little odd... I guess this is just code that's
moving (I guess we could also just return a JSValue / intptr_t from these
helper operations, save the extra instruction).  No need for these ideas to be
incorporated into this patch though.


More information about the webkit-reviews mailing list