[webkit-reviews] review requested: [Bug 64572] Initial implementation of calling WebScriptObject::callWebScriptMethod() via COM : [Attachment 100886] The patch to be committed if/when the bug is approved

[bugzilla-daemon at webkit.org]

Anthony Johnson <anthony.johnson at flexsim.com> has asked  for review:
Bug 64572: Initial implementation of calling
WebScriptObject::callWebScriptMethod() via COM
https://bugs.webkit.org/show_bug.cgi?id=64572

Attachment 100886: The patch to be committed if/when the bug is approved
https://bugs.webkit.org/attachment.cgi?id=100886&action=review

------- Additional Comments from Anthony Johnson <anthony.johnson at flexsim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100886&action=review


> Source/WebKit/win/WebScriptObject.cpp:158
> +	   if (arrayBufferView.get()) {

You may want to look at the next few lines regarding life-cycle management,
i.e. make sure I'm not creating memory leaks here.

> Source/WebKit/win/WebScriptObject.cpp:161
> +	       return new (exec) WebCore::JSArrayBufferView(structure,
globalObject, arrayBufferView);

This is the piece I believe where I'm not getting a proper javascript
Int32Array, as I'm just creating a JSArrayBufferView. However I couldn't find a
JSInt32Array, or maybe I couldn't properly include it without getting compile
errors. For now I think this should be fine, though, until I figure all that
out.