[webkit-reviews] review granted: [Bug 61978] --webkit-visual-word crash on mixed editability : [Attachment 100892] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 61978: --webkit-visual-word crash on mixed editability
https://bugs.webkit.org/show_bug.cgi?id=61978

Attachment 100892: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=100892&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100892&action=review


> Source/WebCore/ChangeLog:3
> +	   Fix 2 --webkit-visual-word crashes:

Nit: we don't usually have this.

> Source/WebCore/ChangeLog:19
> +	   Check previousBoundary/nextBoundary against NULL.
> +
> +	   Have a static function to encapsulate the usage of
getInlineBoxAndOffset and check the 
> +	   visible position is not NULL before passing to
getInlineBoxAndOffset.
> +
> +	   Check the box returned from getInlineBoxAndOffset is not NULL before
accessing.

Can we combine these into one paragraph?  I feel like it's scattered.

> LayoutTests/editing/selection/move-by-word-visually-null-box.html:13
> +	   document.body.innerHTML = "Test Passed";

Maybe you should say "Crash test passed" instead to make it clear that this is
a crash test?

> LayoutTests/platform/qt/Skipped:2486
> +editing/selection/move-by-word-visually-null-box.html

Why this is test skilled in Qt?