[webkit-reviews] review canceled: [Bug 60529] Programmatically set selection should not have direction on Mac : [Attachment 100869] Patch

[bugzilla-daemon at webkit.org]

Wyatt Carss <wcarss at chromium.org> has canceled Wyatt Carss
<wcarss at chromium.org>'s request for review:
Bug 60529: Programmatically set selection should not have direction on Mac
https://bugs.webkit.org/show_bug.cgi?id=60529

Attachment 100869: Patch
https://bugs.webkit.org/attachment.cgi?id=100869&action=review

------- Additional Comments from Wyatt Carss <wcarss at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100869&action=review


>>
LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless.ht
ml:81
>> +	allPlatformsAreBackward = 'backward';
> 
> Ditto.  Also, I don't see any benefit in having these variables around.  It
only bloats the code as far as I can tell.

Using the full object notation on every line makes the lines very hard to read.
these variables seemed like a good way to compress the size and increase
readability. Perhaps I could try "expectForwardOnAllPlatforms" and
"expectBackwardOnMacAndForwardOnUnixAndWin"?