[webkit-reviews] review granted: [Bug 64493] GC allocation fast path has too many operations : [Attachment 100880] the patch (fix windows)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 64493: GC allocation fast path has too many operations
https://bugs.webkit.org/show_bug.cgi?id=64493

Attachment 100880: the patch (fix windows)
https://bugs.webkit.org/attachment.cgi?id=100880&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100880&action=review


> Source/JavaScriptCore/heap/Heap.h:296
> +	   if (UNLIKELY(!firstFreeCell))

Did this have a performance effect?

> Source/JavaScriptCore/heap/MarkedBlock.cpp:135
> +	   new (static_cast<void*>(current)) JSCell(*m_heap->globalData(),
dummyMarkableCellStructure, JSCell::CreatingEarlyCell);

Is this static_cast needed?