[webkit-reviews] review granted: [Bug 64544] Timer scheduling should be based off the monotonic clock : [Attachment 100860] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 64544: Timer scheduling should be based off the monotonic clock
https://bugs.webkit.org/show_bug.cgi?id=64544

Attachment 100860: Patch
https://bugs.webkit.org/attachment.cgi?id=100860&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100860&action=review


> Source/WebCore/platform/SharedTimer.h:44
> +	   // The fire time is based off of WTF::monotonicallyIncreasingTime()
and is not comparable to currentTime().

I think we can omit the WTF:: from this comment.

> Source/WebKit/chromium/public/WebKitClient.h:51
> +// FIXME: remove after rolling deps
> +#define WEBKIT_USE_MONOTONIC_CLOCK_FOR_TIMER_SCHEDULING

I’m surprised this is needed. SharedTimer doesn’t expose what its timebase is
to code outside the class, so how can it matter?

If it does matter, why are we sure that there are not similar issues for WebKit
clients on other platforms? What is the Chromium-specific issue that does not
exist elsewhere?