[webkit-reviews] review granted: [Bug 64492] NRWT doesn't store the svn revision in full_results.json on chromium-win : [Attachment 100839] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 64492: NRWT doesn't store the svn revision in full_results.json on
chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492

Attachment 100839: Patch
https://bugs.webkit.org/attachment.cgi?id=100839&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100839&action=review


> Tools/Scripts/webkitpy/layout_tests/port/base.py:607
> +	   # Config webkit_base_dir() knows where the webkit root is, no other

This is a bit confusing. I'd s/Config
webkit_base_dir()/self._config.webkit_base_dir()/ just to be more clear.