[webkit-reviews] review denied: [Bug 64535] Add fast path for ImageBuffer::draw if accelerated : [Attachment 100824] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 64535: Add fast path for ImageBuffer::draw if accelerated
https://bugs.webkit.org/show_bug.cgi?id=64535

Attachment 100824: Patch
https://bugs.webkit.org/attachment.cgi?id=100824&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100824&action=review


> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:-219
> -	   RefPtr<Image> copy = copyImage();
> -	   ColorSpace colorSpace = (destContext == context()) ?
ColorSpaceDeviceRGB : styleColorSpace;
> -	   destContext->drawImage(copy.get(), colorSpace, destRect, srcRect,
op, useLowQualityScale);

You're ignoring useLowQualityScale in the new code path.

The new code also doesn't do a bunch of stuff that BitmapImage::draw() does:
startAnimation()
mayFillWithSolidColor()
Bail early if part of the image will be drawn.
The shouldUseSubimage stuff.
Adjusting the color space.
Calling  imageObserver()->didDraw().