[webkit-reviews] review granted: [Bug 64481] Implement WKPageCenterSelectionInVisibleArea : [Attachment 100712] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 10:18:32 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 64481: Implement WKPageCenterSelectionInVisibleArea
https://bugs.webkit.org/show_bug.cgi?id=64481

Attachment 100712: Patch
https://bugs.webkit.org/attachment.cgi?id=100712&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1244
> +    if (!frameSelection)
> +	   return;

Frame::selection can never return null, so you can just call
coreFrame->selection()->revealSelection directly.


More information about the webkit-reviews mailing list