[webkit-reviews] review requested: [Bug 61025] Speed up SVGSMILElement::findInstanceTime : [Attachment 100792] Fix for the out of index error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 02:37:55 PDT 2011


Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 61025: Speed up SVGSMILElement::findInstanceTime
https://bugs.webkit.org/show_bug.cgi?id=61025

Attachment 100792: Fix for the out of index error
https://bugs.webkit.org/attachment.cgi?id=100792&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
The reason of the previous assertions is the converse order of the conditions.

if (list[indexOfResult] < minimumTime && sizeOfList - 1 > indexOfResult)

Here the first part was evaluated first even if the second part wasn't true
(which is responsible for the right indexing). So what we should simple do is
just change them.


More information about the webkit-reviews mailing list