[webkit-reviews] review requested: [Bug 63315] [EFL] Add ewk_network.cpp|h files : [Attachment 100778] Modified Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 14 00:06:52 PDT 2011
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 63315: [EFL] Add ewk_network.cpp|h files
https://bugs.webkit.org/show_bug.cgi?id=63315
Attachment 100778: Modified Patch
https://bugs.webkit.org/attachment.cgi?id=100778&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
I make new patch again. I also think it is better to use "ewk_network". Role of
this file supports APIs related to network. So, I move proxy APIs to this file.
I'm sure more APIs will be added because network control is important in mobile
area.
>> You're allowing access to NetworkStateNotifier rather than notifying ewk of
any change.
ewk_network_state_notifier_online_set() is to notify NetwokStateNotifier of
network change. Because, I think WebKit can't know network state without
outside help. So, network change is notified to NetworkStateNotifier through
this APIs when network state is changed.
More information about the webkit-reviews
mailing list