[webkit-reviews] review denied: [Bug 64356] Web Inspector: InspectorResourceAgent should generate unique identifier and save cachedResource for resources from memory cache. : [Attachment 100703] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 13 23:51:26 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has denied review:
Bug 64356: Web Inspector: InspectorResourceAgent should generate unique
identifier and save cachedResource for resources from memory cache.
https://bugs.webkit.org/show_bug.cgi?id=64356
Attachment 100703: Patch
https://bugs.webkit.org/attachment.cgi?id=100703&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100703&action=review
> Source/WebCore/inspector/InspectorInstrumentation.h:-121
> - static void didLoadResourceFromMemoryCache(Page*, DocumentLoader*, const
CachedResource*);
Can we make ResourceData keep const CachedResource* instead? Inspector code
shouldn't modify cached resources.
More information about the webkit-reviews
mailing list