[webkit-reviews] review granted: [Bug 64356] Web Inspector: InspectorResourceAgent should generate unique identifier and save cachedResource for resources from memory cache. : [Attachment 100703] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 64356: Web Inspector: InspectorResourceAgent should generate unique
identifier and save cachedResource for resources from memory cache.
https://bugs.webkit.org/show_bug.cgi?id=64356

Attachment 100703: Patch
https://bugs.webkit.org/attachment.cgi?id=100703&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100703&action=review


> Source/WebCore/inspector/front-end/NetworkPanel.js:760
> +		       originalResource.networkDataRemoved = true;

I don't like the fact that resource is marked as "data removed" independently
on the front-end. It should be either explicit "data collected" event or we
should simply return error upon backend requests in such cases. We are missing
unique identifiers across processes to implement this though.