[webkit-reviews] review granted: [Bug 64499] new-run-webkit-tests: print baseline search path as part of config output : [Attachment 100756] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 64499: new-run-webkit-tests: print baseline search path as part of config
output
https://bugs.webkit.org/show_bug.cgi?id=64499

Attachment 100756: Patch
https://bugs.webkit.org/attachment.cgi?id=100756&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100756&action=review


I would have just printed it one-per line.  Some of these might get very long. 
But it's definitely better than what we have.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:1103
> +	   fallback_path = [x.split(self._port.filesystem.sep)[-1] for x in
self._port.baseline_search_path()]

Why not use filesystem.split?  I would probably have written this map(lambda
path: self._port.filesystem.split(path)[-1], self._port.baseline_search_path())