[webkit-reviews] review granted: [Bug 64495] gardening server should have an API for parsing changelogs : [Attachment 100745] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 64495: gardening server should have an API for parsing changelogs
https://bugs.webkit.org/show_bug.cgi?id=64495

Attachment 100745: Patch
https://bugs.webkit.org/attachment.cgi?id=100745&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100745&action=review


Seems OK.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:61
> +	   head_revision = self.server.tool.scm().head_svn_revision()
> +	   if revision > head_revision:

Seems like we want some sort of "includes_revision()" check somewhere here. 
Either on this class, or preferably on SCM itself. This is OK, but such code
sharing might be better.